search

joshfarrant / slack-clicky

#Clicky is a Chrome Extension which lets you share links to Slack in a single click!
https://chrome.google.com/webstore/detail/clicky-for-slack/bllgmdlgbbmijcoecbnmgeoekhebgmac
MIT License
53 stars 15 forks source link

Context menu command doesn't seem to do anything #15

Open tedepstein opened 6 years ago

tedepstein commented 6 years ago

I see that issue #9 added the ability to right-click a link and send it through the context menu. And I do in fact see Clicky when I right-click a link.

image

But when I choose that menu option, nothing happens.

(Also another user noted that Clicky seems to send the URL of the active tab, rather than the URL of the selected link. Not sure if that issue ever got addressed, and #9 is still closed. You might want to reopen #9 or open a new issue to track this.)

joshfarrant commented 6 years ago

That's strange, just tested this and it's all working as expected.

I'm developing/testing on Mac OS, guessing you're on Windows from the screenshot so maybe there's a chance that this could be platform related.

Before assuming that, however, could I ask you to try refreshing #Clicky's background page? You can do this as follows:

Right-click #Clicky Icon > Manage Extensions > Enable 'Developer Mode' (top-right) > Inspect background.html > Click in opened window to focus it > Ctrl + R to refresh.

I'd be grateful if you could try this and let me know if that fixes the issue.

tedepstein commented 6 years ago

Yes, that fixed it.

image

Nice! ... but maybe there's a way to fix Clicky so this extra step won't be needed?

joshfarrant commented 6 years ago

Great, glad that worked for you.

I'm guessing that the issue is due to a race condition, however I've not properly looked into it yet and may be wrong about this.

I'll take a look when I come to work on #Clicky again.