search

joshfarrant / slack-clicky

#Clicky is a Chrome Extension which lets you share links to Slack in a single click!
https://chrome.google.com/webstore/detail/clicky-for-slack/bllgmdlgbbmijcoecbnmgeoekhebgmac
MIT License
53 stars 15 forks source link

Add feature to continuously share active url #18

Open patcon opened 6 years ago

patcon commented 6 years ago

When I'm sharing my screen on a video call or in a meeting, it's often useful to share the links I travel through directly into a channel.

Would you be willing to accept a new feature that allows for this?

I could imagine two potential implementations via a check-box:

  1. Update a single message with the new url each time a new page is visited, or
  2. Start a thread and drop each new link.

This could be either polling for the browser page at a set interval, or sensing clicks and new urls from omnibox.

Curious your thoughts! Thanks so much for any attention you can give this :)

joshfarrant commented 6 years ago

Hey @patcon, thanks for the request!

I've had a think about this and unfortunately I don't think it's something I'd feel comfortable shipping to #Clicky users, even if it was hidden behind an opt-in checkbox. There's just a bit too much potential for damage for my liking, compared to the (relatively minor) benefits.

A user could potentially enable this without realising, and I know from experience that no matter how many warnings you add, there will still be users who breeze through them without a second thought. Also, I know that (despite my best efforts) the code I write isn't perfect and that there are, and always will be, bugs. This has the potential for some pretty dangerous bugs and, from a selfish point of view, I don't want to be receiving angry emails asking why someone's special links were shared into their work #general channel!

I appreciate that this is a feature that could be useful in situations like those you've described, but I think it's just a bit too niche to justify shipping to all #Clicky users. If this was something that a large proportion of #Clicky users were requesting, then obviously I'd have to consider it.

If this is a feature you'd really like to see implemented, then I think the best solution would be to fork the repo, implement the feature, and then just run your own forked version locally. I'd be happy to point you in the right direction with this if need be.

Probably not the answer you were hoping for, but I hope you can understand the reasons behind the decision! 🙂

patcon commented 6 years ago

Cool! This makes a ton of sense Josh :)

Alternatively, might we be able to add the code with some conditional logic during build, so that the codepath doesn't run or get built into your version, but I can build another extension that does have it? (Perhaps as the only feature).

It feels like it might be fun and modular to figure out how to build two extensions from the same codebase. And this could potentially mean more people in your issue queues helping you out :)

No pressure though :)

joshfarrant commented 6 years ago

Feel free to give it a go. I think forking the repo and modifying it from there will be the best way to move forward with it 👍