JamesFreeman commented 7 months ago

Hi @joshgaber,

Here's a PR for the Laravel 11.x migration, I've spent some time upgrading the CI.yml to now test against the different PHP versions and Laravel versions.

It's worth noting the tests were failing against main, so I've pulled in #59's PR (👏 - great work @kichetof).

I've also migrated the phpunit.xml to the new format and also allow for PHPUnit 11.

I had a couple of issues, with compatibility with Nova 4, so I've migrated the signature of withOrdering in src/Lenses/MockLensRequest.php. I've also disabled testItSucceedsOnPushResponse due to the fact it was deprecated by Nova now anyway because of these changes it might be worth doing this as a Major jump because of the breaking changes.

New Project secret required

As per the new Nova composer format, you'll need to add a new project secret for ${{ secrets.NOVA_4_EMAIL }}

Let me know if you have any questions or need any more changes.

kichetof commented 6 months ago

Hi @JamesFreeman ! This PR is perfect! Thanks! With it, at least 2 issues will be behind us and L11 compatible! Hopefully @joshgaber could take the time to merge it!