joshjaysalazar / iRacingSafetyCarGenerator

Software to generate custom safety cars during an iRacing race
GNU General Public License v3.0
4 stars 2 forks source link

Issue-17: Add tooltips to GUI #24

Closed praneetheus closed 2 months ago

praneetheus commented 3 months ago

Description

Type of change

Testing

joshjaysalazar commented 3 months ago

Apologies for the avalanche of emails you would have received from all of those comments. I'm admittedly not used to being on the dev ops side of things. We're all learning here. lol

praneetheus commented 3 months ago

Thanks for the feedback, lots of learning here haha, will take a look later today.

joshjaysalazar commented 3 months ago

Having an issue running your most recent commit. Didn't want to start a new review if you weren't done, but just wanted to make you aware. constants.json is mispelled, but even after fixing it, the path in the code doesn't seem to be pointing to the right spot.

praneetheus commented 3 months ago

@joshjaysalazar Addressed the comments. The build was failing because I fat fingered the file name. Fixed it in the latest commit

joshjaysalazar commented 3 months ago

So, when you're ready for me to look again, you can re-request a review. That way I'm not accidentally looking at unfinished work without knowing it.

joshjaysalazar commented 2 months ago

Any chance of wrapping up this PR? I don't want it to get too far behind the main branch.

praneetheus commented 2 months ago

Addressed the feedback, made the suggested changes. Please take another look

joshjaysalazar commented 2 months ago

Addressed the feedback, made the suggested changes. Please take another look

Awesome, I will review when I have a chance this week.

praneetheus commented 2 months ago

Addressed the feedback