search

joshjg / react-canvas-knob

Flexible knob/dial input component
MIT License
44 stars 28 forks source link

Updating props #11

Closed dschu-lab closed 7 years ago

dschu-lab commented 7 years ago

Hi there,

I'm currently trying to implement this into a responsive page, but once the knob is rendered the first time, I'm unable to update the width/heights, because they are only set once (inside the constructor).

Is there a implementation of componentWillReceiveProps() on the road map or a Pull Request of this feature already there? If not, I'm willing to implement this feature, if you want. 🍻

dschu-lab commented 7 years ago

Just wrote a little pull request which implements componentWillReceiveProps for width & height. 😄

joshjg commented 7 years ago

Merged PR-12