joshjg / react-canvas-knob

Flexible knob/dial input component
MIT License
44 stars 28 forks source link

Error #20

Open saiteja2145 opened 6 years ago

saiteja2145 commented 6 years ago

Failed to compile. ./node_modules/react-canvas-knob/index.js Module not found: Can't resolve 'react-transform-catch-errors' in '/home/vvdn/my/node_modules/react-canvas-knob'

andrefox333 commented 6 years ago

I simply did a npm i react-transform-catch-errors@latest and it worked...

marcusmathioudakis commented 6 years ago

react-transform-catch-errors is a deprecated project (see https://github.com/gaearon/react-transform-catch-errors)...

goldensunliu commented 6 years ago

@andrefox333 I would suggest you just fork this repo and remove the react-transform-catch-errors dep.

marcusmathioudakis commented 6 years ago

Thanks will do. Feels like this should be removed by author eventually too given that its a deprecated library, no?

On Tue, Nov 7, 2017 at 3:21 PM, Sitian Liu notifications@github.com wrote:

@andrefox333 https://github.com/andrefox333 I would suggest you just fork this repo and remove the react-transform-catch-errors dep.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joshjg/react-canvas-knob/issues/20#issuecomment-342626212, or mute the thread https://github.com/notifications/unsubscribe-auth/ARx0OoN3NY65XAVleroo7KY1NhuFpMsVks5s0Mn2gaJpZM4QS8dW .

kjaku commented 6 years ago

Can you guys explain how to remove this dep? I deleted it from package.json, but index.js from knob module is using it so it give errors, so I commented "require" line var _reactTransformCatchErrors3 = require('react-transform-catch-errors'); but then the later usage in code bring errors. So removing this dep means to track all usage of "react-transform-catch-errors" in code and change it somehow?

timbroder commented 6 years ago

@marcusmathioudakis did you make headway with removing react-transform-catch-errors? About to take a stab at it otherwise. Thanks

marcusmathioudakis commented 6 years ago

Hey Tim - unfortunately not, go for it!

On Tue, Mar 13, 2018 at 6:59 PM, Tim Broder notifications@github.com wrote:

@marcusmathioudakis https://github.com/marcusmathioudakis did you make headway with removing react-transform-catch-errors? About to take a stab at it otherwise. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joshjg/react-canvas-knob/issues/20#issuecomment-372780973, or mute the thread https://github.com/notifications/unsubscribe-auth/ARx0Olz9kbADlISDkiBvEh7SQgPk3Qydks5teBcegaJpZM4QS8dW .