joshjhargreaves / react-native-event-calendar

A React-Native iOS style calendar implemented using VirtualizedList.
MIT License
216 stars 104 forks source link

Event color not working #23

Open LBianchi98 opened 6 years ago

LBianchi98 commented 6 years ago

Maybe it should be my mistake but i'm trying to change some events' color but it remains the same.

RetroSGJacobs commented 5 years ago

Could possibly be due to #17. Try setting the version in your package.json to point to "git+https://github.com/joshjhargreaves/react-native-event-calendar.git", I think that should work?

BobsonTheFirst commented 5 years ago

I encounter the same problem, the event color won't change. I changed the version in my package.json, but it doesn't work (see below). Any other suggestions?

"repository": { "type": "git", "url": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git" },

RetroSGJacobs commented 5 years ago

Hmm, have you perhaps tried adding the dependency like this?

"dependencies": {
    "react-native-events-calendar": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git",
}

If this doesn't work, feel free to try my own fork "git+https://github.com/RetroSGJacobs/react-native-event-calendar.git", although I haven't quite kept track of the new changes since my PR. I hope this helps!

BobsonTheFirst commented 5 years ago

Hi, thanks for your fast reply.

Unfortunately your both suggestions aren't working. I added the dependencies and used your fork. So I am afraid I am doing something wrong?

RetroSGJacobs commented 5 years ago

Perhaps try to manually delete the react-native-event-calendar npm package and perform an npm / yarn install? Normally if making such a change it is necessary to do so, assuming you haven't already tried this.

BobsonTheFirst commented 5 years ago

I started a clean new project to see if maybe something was wrong inside my project. After following your instructions, it worked. So indeed, adding/changing the following in the package.json file helped:

"dependencies": { "react": "16.6.3", "react-native": "0.57.8", "react-native-events-calendar": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git" }, "repository": { "type": "git", "url": "git+https://github.com/joshjhargreaves/react-native-event-calendar.git" }

Now i have to figure out how to fix the colors in my own project. Thanks!

RetroSGJacobs commented 5 years ago

Awesome, glad to hear you got it sorted!