Closed BruceHaley closed 2 years ago
Nice! Thank you for the pull request @BruceHaley. A lot of great enhancements here!
I will get back to you soon after my review 😄
I might suggest some of these be put behind flags (ie: to ignore done items, adding a comment in ADO (which is awesome by the way)), but my initial look through 👍
Glad you like it. Feel free to make any modifications you see fit.
I made some small tweaks, like adding bools for ado_migrate_closed_workitems
and ado_production_run
(for adding tag+comment on ado work item after migration).
Thank you for your contributions! 🎉 🚀
In this PR, I changed it from gh_add_ado_comments
to gh_migrate_ado_comments
But then when updating the readme, I didn't like it as much since it's not really migrating comments, it's just adding it as a section in GitHub. In a subsequent commit, I reverted that particular change :).
Changes
-Encoding ASCII
to file writes. Default is Unicode. Our GitHub repos are not set up for Unicode text in issue and comment bodies.