search

joshjowen / script.json-cec

cec control for xbmc/kodi
GNU General Public License v2.0
71 stars 34 forks source link

Compatibility with Python3/Kodi 19 #14

Closed peci1 closed 3 years ago

peci1 commented 3 years ago

This was enough for me to fix the addon on Kodi 19.

I'm sending a PR against the master branch, however according to the main plugin repository docs, Kodi Matrix (19+) should have its own branch that is distinct from all other branches for Kodi 18-. The main reason is that for the plugin repository to show the plugin on Kodi 19, it searches addon.xml and shows only addons that require xbmc-python in version 3.0.0+. That would, on the other hand, disable the plugin on older versions of Kodi. So that's why a separate branch is required for Matrix.

joshjowen commented 3 years ago

I am no longer using Kodi and am unable to test these changes, and as such would prefer not to accept pull requests. I am looking to transfer ownership of this repo however. So let me know if you are interested in that.

MichlW commented 3 years ago

I can confirm that these changes work as it should on Kodi 19. I am using LibreELEC 10 BETA1 on RPi4 and managed to get it work after changing the two files as in this PR. Thanks alot!

peci1 commented 3 years ago

Thank you for testing it, @MichlW ;)