search

joshmarshall / jsonrpclib

A Python JSON-RPC over HTTP that mirrors xmlrpclib syntax.
Other
447 stars 144 forks source link

Fix for issue 34 #36

Closed rayrapetyan closed 9 years ago

rayrapetyan commented 9 years ago

Fix for https://github.com/joshmarshall/jsonrpclib/issues/34

joshmarshall commented 9 years ago

@rayrapetyan Appreciate the pull request! Did you happen to try calling super()'s instead of explicitly calling individual init()s? You might try that instead, since that's the proper inheritance order. Of course, you might need to write a wrapper class for XMLTransport since it's an old-style class.

rayrapetyan commented 9 years ago

Yep, I've tried that first, but it didn't worked (constructor of a SafeTransport class was not called yet). I read about some tricks and hacks for incorporating a non-cooperative classes but then decided it would be an overkill for this case (as I'm against multiple inheritance at all but it's another story)... I'll better work on a next fix related to invalid SSL cert (I think most of development envs has self-signed certs) and will provide a patch soon.