search

joshmcarthur / spree-import-products

A Spree extension to allow users to batch upload Products from a CSV file using Delayed Job
http://spreecommerce.com/extensions/103-import-products
BSD 3-Clause "New" or "Revised" License
80 stars 97 forks source link

Testing + spree 1.0.x #16

Open sbounmy opened 12 years ago

sbounmy commented 12 years ago

This pull request :

joshmcarthur commented 12 years ago

OK, so here's what I'm going to do with this one:

I'm going to use #14 as a base, because it's much cleaner, and I can easily see exactly what it's doing. From then, I am going to use @sbounmy's commits that add testing (woohoo!), and some nice additions to the import.

I think this is the best mix of a clean upgrade patch to 1.0, and new functionality.

17 I am going to merge into it's own branch - it's too bigger change for merging into the 1_0_x branch, I think.

sbounmy commented 12 years ago

sounds good to me ! glad to see that my import additions will be merged ;) thanks @joshmcarthur