Implement config parsing

joshmedeski / sesh

Smart session manager for the terminal

MIT License

417 stars 17 forks source link

Implement config parsing #22

Closed joebonneau closed 5 months ago

joebonneau commented 5 months ago

Implements parsing of a sesh/sesh.toml config file and creates a pattern for future use

Open discussion/items:

Do we like the pattern of parsing the config file in the main cli command? This prevents us from re-running this logic over and over again within a single call, but does introduce a bit of prop drilling that clutters things up a bit.
The scaffolding to implement the "include root dir in session name" feature is there, but is on hold until we determine whether we want to keep that or not

Here's what the config looks like so far (super barebones):

[session.name]
include_root_dir = true

Also, not sure why my commits from the previous PR are showing up here. If there's some better way to be doing this, let me know... I basically just updated my fork from your repo and then added commits to it.

joshmedeski commented 5 months ago

I'm checking with Tom about how he uses this parent dir feature. I'm gonna put this PR on hold until I decide we have something work using for a configuration file.

joebonneau commented 5 months ago

I'm checking with Tom about how he uses this parent dir feature. I'm gonna put this PR on hold until I decide we have something work using for a configuration file.

Sounds good. Something that I think it could be used for is specifying startup scripts. I'm thinking it could be set up such that you link a path to a startup script wherever you want to store them, and it'll execute that script after creating the session.

All good either way, happy to work on something else entirely in the meantime!

joshmedeski commented 5 months ago

For #7

joebonneau commented 5 months ago

@joshmedeski I implemented the startup scripts feature and added some docs to go along with it. For now, users can only run persistent scripts, i.e. the created session won't exit when the script exits. I think this is likely what people will want most of the time anyway, but we can implement the opposite behavior down the road if people are interested.

Might need some help with resolving the merge conflicts, though... not entirely sure what the best way of doing that is with go.mod and go.sum.

joshmedeski commented 5 months ago

Another merge conflict. But for now can we drop the parent session name? I'd like to address #33 and I'll be adding nerd font support soon, which will be need a config option ;)

joshmedeski commented 5 months ago

Sorry for all the merge conflicts, @joebonneau!

I'll review all of this tonight and hopefully we can get it merged very soon.