joshmedeski / t-smart-tmux-session-manager

t - the smart tmux session manager
326 stars 51 forks source link

Convert tmux variables to shell variables #72

Closed joshmedeski closed 12 months ago

joshmedeski commented 1 year ago

I originally started customizing this plugin using tmux variables which can't be read if tmux isn't running. So I switched to using shell variables (ex: T_SESSION_NAME_INCLUDE_PARENT) for some customizations in order to fix this issue.

This has left the user with two different places to customize the plugin (tmux variables or shell variables), which I think creates additional complexity for managing this plugin.

After some thought, I believe it's best to drop all tmux variables in favor of shell variables, here is my reasoning so that all customizations are in one place and work whether or not tmux is currently running.

I've also been able to simplify the README and show all configurations together, hopefully making it easier for people new to the shell and tmux to be able to approach customizing this shell to their needs more easily.

The added bonus is the bash code can use a fallback value inline during assignment, reducing the code significantly.

🚧 BREAKING CHANGE 🚧

The following tmux variables are dropped in favor of new shell variables.

joshmedeski commented 1 year ago

I'm open to feedback on these questions.

joshmedeski commented 12 months ago

I'm going to rework this so there are less variables you have to handle and you can just pass any/all fzf flags in one variable.