Closed lukeberry99 closed 10 months ago
+1 on this one, it seems like -v
doesn't work correctly, check screenshot. It doesn't crash in my case, however I can't set colorscheme using this variable, but if I change -v
to -z
in the t
script file it does work as intended
After update it's working even with -v
, I don't understand why, considering testing with echo
, but at least I can set up my colorscheme
It's stating a "syntax error". What version of bash is on your machine? (bash --version
).
I require bash >= 4.0 for this project to properly work.
I was running 3.2 - but I've upgraded to 5.2.21 and it does fix it.
For what it's worth, I do have a branch that gets this working for me in bash 3.x - https://github.com/lukeberry99/t-smart-tmux-session-manager/tree/fix/fzf-tmux-opts
But unsure if that's warranted, I missed the min bash version on the README and it works as expected if you're using the correct setup 😂
I think it's a good idea to update the switch case. I will make a quick commit this week.
Check out the latest release, I downgraded the script to bash v3: https://github.com/joshmedeski/t-smart-tmux-session-manager/releases/tag/v2.7.0
If there are no
FZF_TMUX_OPTS
set thent
crashes with the following outputDon't we want to be setting
-z
to check ifFZF_TMUX_OPTS
is unset, and if it is we give it a default value? Whereas right now we're checking if it is set, and then overwriting it if it is?Happy to make a PR to this effect