search

joshmfrankel / simplecov-check-action

SimpleCov+ Action
MIT License
32 stars 16 forks source link

Use api url from environment (fix for GHES), use debian image, fix specs #19

Open steve21168 opened 7 months ago

steve21168 commented 7 months ago

Hi, this is a fix for using Github Enterprise Server API url. I've also updated the Dockerfile to use the slim image as opposed to alpine. My environment has DNS issues related to alpine images, this is a well documented issue that has to do with alpines use of musl C library.

I've also fixed the specs, whose failure was unrelated to this PR.

joshmfrankel commented 3 months ago

@steve21168 Thanks for digging into the spec failures and the update to the enterprise server api. There was a recently merged pull request here: https://github.com/joshmfrankel/simplecov-check-action/pull/20 which may fix your underlying issue.

steve21168 commented 3 months ago

@joshmfrankel Hi thanks for the response. This should fix the GH api url issue. Unfortunately I still suffer from the alpine image issue. Just tested and I get an error message:

/usr/local/lib/ruby/3.1.0/socket.rb:227:in `getaddrinfo': Failed to open TCP connection ...

This is somewhat specific to my environment but I doubt I am the only one. Would you consider a PR just changing to the slim image?