joshmfrankel / simplecov-check-action

SimpleCov+ Action
MIT License
32 stars 16 forks source link

Compatibility with `simplecov_json_formatter` #8

Closed clinejj closed 1 year ago

clinejj commented 2 years ago

The simplecov_json_formatter gem is bundled with simplecov and looks to be the recommended gem according to the documentation (see here). Any thoughts as to supporting the output of this instead of simplecov-json (or both)?

The main issue appears to be the files key isn't present in the other format, which also doesn't generate a file by file summary and this would have to be calculated instead to support the minimum_file_coverage configuration (see sample)

joshmfrankel commented 1 year ago

That is a fair point. The reason I went with https://github.com/vicentllongo/simplecov-json was that it included several things I wanted to measure from SimpleCov's resultset.

Specifically:

We could utilize the recommended gem but would have to calculated the coverage percent for every file as well as overall suite coverage. Since vicentllongo/simplecov-json provided this directly, it was a more efficient way to complete this Github action. I don't have any plans at this time to change the json gem utilized but pull requests are welcome 👍🏻