search

joshmh / globalize2

The second incarnation of Globalize for Rails
http://www.globalize-rails.org/
MIT License
364 stars 57 forks source link

not raising missing translations exception #20

Open kittyflat opened 14 years ago

kittyflat commented 14 years ago

via http://groups.google.com/group/rails-i18n/browse_thread/thread/44df06eed78c0516

Hi,

I am using Globalize2 in some projects, and recently noticed that I don't get any notices that there are missing translations (no text show up, and no entry in the missing translations log). I suspect that it is these lines in the static.rb file that is to blame:

    translation(result, attrs)

translation(result, attrs) || raise(I18n::MissingTranslationData.new(locale, key, options))

Now I wonder if there is a reason for this, and if there is another way that is more preferred or if it was just something that was overlooked? (also, if I change it back, will there be something else that will break that is depending on this new behaviour)

Regards, Jimmy

kittyflat commented 14 years ago

I have the same question

http://github.com/joshmh/globalize2/commit/133da77c3c09618caffb41ba0324f81c18aabd53

seems like it was meant to fix class reloading issue, but the author who committed the change wrote that it was "dubious."