search

joshmn / ahoy_captain

A full-featured, mountable analytics dashboard for your Rails app, powered by the Ahoy gem.
MIT License
356 stars 18 forks source link

Fresh install immediately crashes due to missing `javascript_importmap_shim_tag` #39

Open johnmcdowall opened 8 months ago

johnmcdowall commented 8 months ago

Fresh installation, with Rails 7.1.2:

undefined local variable or method `javascript_importmap_shim_tag'

I think this is caused by the dependency you have in the .gemspec liberally accepting any version of importmap-rails >=1, and DHH has removed the shim in > 2.0.

johncjensen commented 7 months ago

Having the same exact issue. @joshmn ?

kieranklaassen commented 7 months ago

Same!

johnmcdowall commented 7 months ago

I opened a PR for this a few weeks back: https://github.com/joshmn/ahoy_captain/pull/40

scottcmerritt commented 7 months ago

I experienced this issue as well. This engine appears nice and useful, it would be nice to try it out with rails 7.1.2

krzysztofkeczkowski commented 7 months ago

Same. @joshmn ?

tomatkapitalise commented 7 months ago

Can confirm @johnmcdowall has a fix with #40 which can be applied with the gem line of:

gem "ahoy_captain", git: 'https://github.com/johnmcdowall/ahoy_captain.git', branch: 'fix_importmaps'

Would be great to see this merged. Thanks for the work.

beydogan commented 6 months ago

Can also confirm https://github.com/joshmn/ahoy_captain/pull/40 fixes the issue with me on a Rails 7.1 app.