Warnings: Use `alias_method` > `alias_attribute` for non-attributes

joshmn / caffeinate

A Rails engine for drip campaigns/scheduled sequences and periodical support. Works with ActionMailer, and other things.

https://caffeinate.email

MIT License

345 stars 13 forks source link

Warnings: Use `alias_method` > `alias_attribute` for non-attributes #45

Open jon-sully opened 10 months ago

jon-sully commented 10 months ago

Eliminate nags!

Fixes #43

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3f41563) 98.68% compared to head (ae31ce5) 98.68%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #45 +/- ## ======================================= Coverage 98.68% 98.68% ======================================= Files 102 102 Lines 2664 2664 ======================================= Hits 2629 2629 Misses 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jon-sully commented 10 months ago

This one's ready. No functional change at all, just swapping a method for a Rails 7.2 compatibility

jon-sully commented 10 months ago

@joshmn any chance you could take a peek at this one?

cloke commented 2 months ago

Any chance of getting this merged in? With rails 7.2 being officially released this is a blocker for sure.

jon-sully commented 1 month ago

All, I've reached out to @joshmn a couple of times... if he remains unavailable for another week or two, I will (sadly) fork this project and keep it up to date. I'm not sure exactly why he's been MIA lately. This gem should never block Rails upgrades.

jon-sully commented 1 month ago

Welp, figured that out.

https://www.yahoo.com/tech/man-ran-website-illegally-streamed-214600421.html?guccounter=1

Guess a fork is on the way.