joshnewans / articubot_one

249 stars 219 forks source link

Update rsp.launch.py #7

Open neochaos42 opened 1 year ago

neochaos42 commented 1 year ago

Fixes rsp.launch.py to load robot description as a string

neochaos42 commented 1 year ago

Without this patch it tries to load the xacro as a yaml file which is undesired

joshnewans commented 1 year ago

Thanks, I had been meaning to chase this one down! (I had seen the warnings but not looked into it as it seemed to work).

I'll merge it in once I have a chance to flag it in a video so that things are kept in sync :)

neochaos42 commented 1 year ago

May need to change this line too https://github.com/neochaos42/articubot_one/blob/76dd9c412cf8f92c5f65b4a996269bf4ada1b441/launch/launch_robot.launch.py#LL49C4-L49C105

neochaos42 commented 1 year ago

For me rsp would not launch at all without this patch

joshnewans commented 1 year ago

Really? With everything else the same? I have had no issues (bar the occasional warning), tested on Foxy and Humble (only sim on Humble so far, hopefully running on the robot this week). I'd really like to understand the exact context in which it fails (certain xacro files maybe?).

I don't really want to merge it blindly without flagging it in a video since they are meant to be kept "in sync" but I will definitely make it a priority (and hopefully others with the same issue who are capable will find your fixes here).

neochaos42 commented 1 year ago

I will link my repo Note I have only gotten to https://articulatedrobotics.xyz/mobile-robot-12a-ros2-control-extra/

https://github.com/neochaos42/wubot

neochaos42 commented 1 year ago

Based on foxy with only slight variations due to my robot design