search

joshp23 / YOURLS-Expiry

YOURLS plugin to define conditions under which links will expire - time and click limited links
GNU General Public License v3.0
35 stars 13 forks source link

Do not redirect if CLI mode #17

Closed vitalyzhakov closed 4 years ago

vitalyzhakov commented 4 years ago

@joshp23 , thank you for solving https://github.com/joshp23/YOURLS-Expiry/issues/15! But it does not work for me properly. It removes one link and die with html output.

I have added some checks. Can your merge it?

vitalyzhakov commented 4 years ago

@joshp23 , OK, files changed. Additionally, I deleted // ini_set('max_execution_time', 3000);, because by default php from CLI sets it to 0 https://www.php.net/manual/en/info.configuration.php#ini.max-execution-time

joshp23 commented 4 years ago

I put the // ini_set('max_execution_time', 3000); back. It seems useful to me to keep it there for the reverse of your issue, if folks require the limit for whatever reason. Also, please remove the 3 commits addressing memory consumption from this pull request, I would put them in another branch and open another pull request for them, specifically. I may go in another direction to address that issue, and would not like to commit that at this time.

vitalyzhakov commented 4 years ago

@joshp23 , ok, no problem)