search

joshp23 / YOURLS-Expiry

YOURLS plugin to define conditions under which links will expire - time and click limited links
GNU General Public License v3.0
35 stars 13 forks source link

Add an option to automatically remove the url when expires #41

Open westor7 opened 2 years ago

westor7 commented 2 years ago

Hello,

I'm using this plugin and seems very useful , but one thing that is good to see is when a url expires to automatically remove that link from admin panel and database, because it has no sense to keep expired links there, so when someone try to access that expired link then a 404 seems fair.

pfeifferch commented 1 year ago

Hello @ all.

For me it's the other way around, I would like to keep the page "the short URL has expired" so that the ID is not reassigned. A link or bookmark would eventually lead to the wrong landing page. Here it would be useful if the admin could set the setting according to his preferences The English text has been machine translated, sorry

Hallo @ all.

Bei mir ist es genau andersrum, ich würde gerne die Seite "der Short URL ist abgelaufen" behalten, damit die ID nicht neu vergeben werden. Ein Link oder gesetztes Lesezeichen würde irgendwann zu einer falschen Zielseite führen.

Hier wäre es praktisch, wenn der Admin die Einstellung nach seinen Vorlieben setzen könnte.

brknkfr commented 3 months ago

For me it's the other way around, I would like to keep the page "the short URL has expired" so that the ID is not reassigned. A link or bookmark would eventually lead to the wrong landing page. Here it would be useful if the admin could set the setting according to his preferences The English text has been machine translated, sorry

I created a pull request for that functionality, see https://github.com/joshp23/YOURLS-Expiry/pull/46

brknkfr commented 3 months ago

Can't you just set up a cronjob which calls the api and deletes the expired links?