search

joshp23 / YOURLS-Expiry

YOURLS plugin to define conditions under which links will expire - time and click limited links
GNU General Public License v3.0
35 stars 13 forks source link

Wrong icon paths when installed in a subdirectory #5

Closed beceha closed 6 years ago

beceha commented 6 years ago

There is a wrong path for the settings page's icons of YOURLS-Expiry, when YOURLS is installed in a subdirectory.

The icon for "remove expiry" and the icon for "Strip postx" is missing due to wrong paths:

Screenshot: https://i.imgur.com/NfqJnXf.png

Graphic Info from browser: https://i.imgur.com/mp3bh4X.png

For example the path for the YOURLS logo is: https://mysite.de/empfiehlt/images/yourls-logo.png

But the paths of the "Expiry" settings page icons is: https://mysite.de/images/delete.png

"empfiehlt" is my subdirectory for the YOURLS installation, which is missing in the icon's path of Expiry plugin.

YOURLS 1.7.3 PHP 7.1.11 Browser: Firefox 61.0.1 Desktop

joshp23 commented 6 years ago

Sure, I can have a go at that later, when I have time. I am open to pull requests ;)

joshp23 commented 6 years ago

latest commit should fix it

beceha commented 6 years ago

Yes, great, thanks a lot!

joshp23 commented 6 years ago

go ahead and update. I fixed a critical bug where expired links weren't expiring.