search

joshp23 / YOURLS-IQRCodes

YOURLS QRCode plugin with exposed options and full integration
GNU General Public License v3.0
22 stars 11 forks source link

Broken image on admin page share box #13

Closed joshp23 closed 6 years ago

joshp23 commented 7 years ago

When the admin page loads and I open the share box for a particular link the image is broken. I think this has something to do with #2

If I re-open the link (press the share icon a second time) the image loads fine, and every subsequent image loads just fine.

joshp23 commented 7 years ago

Fixed with 7ea9461 and stable in latest release (=>1.1.3).

joshp23 commented 7 years ago

The above fix still works as intended, but it appears as if there is a second reason that this issue occurs which has something to do with how srv.php creates time sensitive links. So, while the above fix works 95% of the time, the same effect will randomly occur.

Probably will just switch to cookies to solve the issue at some time in the future. Not high on priority list.

jkrobin commented 7 years ago

A quick thank you to you all, and also a note to let you know that I, too, am still experiencing this issue with the broken QR image in the admin page share box. Subsequent loads/presses of the share icon do not fix the issue -- they just never appear in the share box.

All QR codes have, however, been generated through the bulk generation function in settings.

joshp23 commented 7 years ago

Do they show up in the share box of the stats page?

jkrobin commented 7 years ago

@joshp23 No, they don't show in the share box of the stats page, either.

joshp23 commented 7 years ago

then you have an issue with your configuration. check that you followed the instructions and try again. Look through old issues for clues.

jkrobin commented 7 years ago

Will do. Thanks.

On Thu, Nov 2, 2017 at 4:13 PM, Josh Panter notifications@github.com wrote:

then you have an issue with your configuration. check that you followed the instructions and try again. Look through old issues for clues.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joshp23/YOURLS-IQRCodes/issues/13#issuecomment-341544195, or mute the thread https://github.com/notifications/unsubscribe-auth/AfwMRtyOt4DUOUZe53NUvHUatjuiUwscks5syiJ2gaJpZM4N0tWA .

m4th2 commented 7 years ago

I have the same issue, admin page loads and I open the share box for a particular link the image is broken. QR codes are OK in /user/cache/qr even if my logo.png is not inside. But QR codes works fine. Installed with FTP, user/cache/qr created -> 777 OK user/plugins/iqrcodes -> 777 OK recursively done.

I do not understand this (i am french and google search do not help me to understand what to do) : "Symlink assets/srv.php to YOURLS/pages/srv.php Symlink assets/qrchk.php to YOURLS/pages/qrchk.php"

It may be the issue solution ... Or not ^^

joshp23 commented 7 years ago

What happens when you click the share button a second time?

m4th2 commented 7 years ago

Hi Joshp23, thanks for answer.

Same issue, refresh or second time click do not make png ...

URL broken png : <img id="myid" src="http://2go.ovh/srv/?id=iqrcodes&amp;key=9ada5c024108cc4c72718aa2a7810811&amp;fn=qrc_14436b8cd9cfdfa9748868358b414909.png" style="width: 100px; height: 100px;">

Pictures OK in folder http://2go.ovh/user/cache/qr/ [http://2go.ovh/user/cache/qr/qrc_14436b8cd9cfdfa9748868358b414909.png]

Should i copy assets/srv.php into /pages/ folder ? It will solve the issue ? Should i copy assets/qrchk.php into /pages/ folder ? It will solve the issue ?

I am sure my problem is "simlinks", same issue #20 https://github.com/joshp23/YOURLS-IQRCodes/issues/20

May i used .htaccess to symbolic links ?

joshp23 commented 7 years ago

@cent20fr Are you, by chance, running under Apache or Nginx? If you are running under Nginx, see this note.

If you don't get the image when you click a second time in the admin page, do they show up in the share page?

I would check to see if any of the following work:

If neither of those fix your problem

Did any of those suggestions fix your issue?

@jkrobin Did you solve your problem, is any of this useful?

joshp23 commented 7 years ago

@cent20fr If you still experience issues, I noticed that there seems to be something odd in your URL. Here's what a good qrcode image url looks like:
https://example.com/srv/?id=iqrcodes&key=HASH_STRING&fn=qrc_HASH_STRING.png
here's yours: https://example.com/srv/?id=iqrcodes&amp;key=HASH_STRING&amp;fn=qrc_HASH_STRING.png Do those amp;'s appear in your url as well?

Incidentally, the qrcodes should appear if your system is properly configured. The original broken image bug has been fixed, and is currently tied to a timing issue, and this will be addressed in the future... eventually. See this comment

m4th2 commented 7 years ago

I've no ssh access, no symlinks possible, so i won't be able to fix my issue by this way. (no root access, just free shared hosting for small project, fun tests)

image

Permissions are good i think.

image

Broken image

image

URL

image

no "amp;" in URL, just copy - paste who make it appears... ^^ Sorry for my lack of vigilance.

I have tried to copy files qrchk.php and srv.php and it works !!!

image

So issue solved,

Really thank you very much for helping me, I regret not having dared to make this copy stuck by itself ...

Remove the symlinks and copy the files instead:

cp ./qrchk.php /path/to/YOURLS/pages/qrchk.php
cp ./srv.php /path/to/YOURLS/pages/srv.php

qrchk replaced by srv on second ligne of your message.

Tanks a lot,

image

Solution :

If you do not have the ability to make symlinks, you can try to duplicate the qrchk.php and srv.php files in /path/to/YOURLS/user/plugins/iqrcodes/assets/ and place the copy same (same name, same version ...) in the folder /path/to/YOURLS/pages/

joshp23 commented 6 years ago

That's a lot of effort just to say that copying the files worked. I'm closing this.