adding odds without incorrect math

joshpelkey / cfbets

College football betting web app, built with django/bootstrap/jquery

Apache License 2.0

15 stars 8 forks source link

adding odds without incorrect math #53

Open chrisbellande opened 6 years ago

chrisbellande commented 6 years ago

I'm bored, so doing this again. The user experience could probably use a little work since this is pretty backend-friendly (I'm also very backend-friendly, if you catch my drift)...maybe could build out like a little helper so that they can pick the odds visually and then use that to calculate the decimal value or something. Or just assume that people using this aren't dumb and know what odds are

Concerns:

floating point calculations (e.g. will it think that an odds value is != 1 when it should be one and change the transaction amount). Probably not, and even if so the change would be negligible since money is only relevant to two decimal places
John's golf swing and lack of distance
Trump

joshpelkey commented 6 years ago

My main concern here is also John’s golf swing and lack of distance. Also that the data model stores current balance and overall winnings as integers. I see you gitignored vscode but LOL’d tests. Did you try this out? Overall it looks pretty solid. Id like to make it more UI friendly but we can try it in dev without that. Ill let you know if it goes up (thats what he said).

chrisbellande commented 6 years ago

Should be pretty straightforward to migrate the winnings to a decimal field though right? That is probably better in general for a currency field anyway. I didn't try it out bc I didn't feel like going digging around with the steps to get it running locally...would i just need to grab the stuff in requirements.txt? Might be able to setup with a package manager at some point to make dev process easier

joshpelkey commented 6 years ago

Yeah should be easy, but not as easy as just pulling your changes lawl. You can get setup by:

mkvirtualenv to create dev environment
pip install -r requirements.txt to install all reqs
Set up mysql db (i can send you an export if you wanted more data)
Create local_settings.py with db info, etc (i can send example)

I could probably put this all ina container somehow and make it much easier, but have never done before. GCP might even do it for me....might look into it.