search

joshpeng / One-Dark

Atom's One Dark theme for Visual Studio Code
MIT License
15 stars 2 forks source link

Support for Flowtype #6

Closed kumarharsh closed 6 years ago

kumarharsh commented 6 years ago

Hi, I've been using this syntax for quite some time, and it's really great. I am working on React and am using Flow annotations. Would you be interested in adding support for 'type' imports in JS, and some flow-specific syntaxes? Some examples to show where this syntax needs to be improved:

  1. Type imports mixed with normal imports: image The first type imported breaks the subsequent highlighting.
  2. Putting types on class properties breaks the highlighting: image

There are a bunch more issues, but I think you get the idea. Can you add better flow support?

joshpeng commented 6 years ago

This is something that would probably need to be implemented on the upstream Sublime Babel extension that this theme utilizes. I have another request over there for this as well, but just haven't had time to dive into it yet. Hopefully will in the nearish future.