Closed joshprzybyszewski closed 2 years ago
Merging #113 (46b9123) into master (f7aa4c4) will decrease coverage by
0.10%
. The diff coverage is30.00%
.
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
- Coverage 70.47% 70.37% -0.10%
==========================================
Files 86 87 +1
Lines 3948 3965 +17
==========================================
+ Hits 2782 2790 +8
- Misses 894 904 +10
+ Partials 272 271 -1
Impacted Files | Coverage Δ | |
---|---|---|
server/persistence/dynamo/utils.go | 100.00% <ø> (ø) |
|
server/server.go | 57.25% <0.00%> (-1.62%) |
:arrow_down: |
server/setup.go | 0.00% <0.00%> (ø) |
|
server/cors_config.go | 100.00% <100.00%> (ø) |
|
server/play/cut.go | 50.00% <0.00%> (+5.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f7aa4c4...46b9123. Read the comment docs.
What broke / What you're adding
lambdas are almost ready (see https://github.com/joshprzybyszewski/cribbage/pull/111). There's some things that'll be good to have in before that. let's do that.
How you did it
DDBid
->gamesV1
define a baseURL in the client network requests (so that we can hit a different domain). add CORS to http request handling. add a backdoor endpoint to see if its working or not.How to test it and how to try to break it