search

joshprzybyszewski / cribbage

A cribbage scorer and game
MIT License
2 stars 1 forks source link

Add timestamps to player's actions and use case-sensitive collation #78

Closed joshprzybyszewski closed 4 years ago

joshprzybyszewski commented 4 years ago

What broke / What you're adding

Add timestamp to actions. Use a case-sensitive collation.

How you did it

Put a column on the Games mysql DB table that defaults to current time. This should be "good enough" to tell us when a game was started and when the last move was.

I learned a lot from this article and this stack overflow about collations.

How to test it and how to try to break it

Look at the active games table for games that have moves. See timestamps set now. Add a player dave and another Dave. See them be different.

codecov[bot] commented 4 years ago

Codecov Report

Merging #78 into master will increase coverage by 0.26%. The diff coverage is 96.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   71.38%   71.64%   +0.26%     
==========================================
  Files          73       73              
  Lines        3809     3826      +17     
==========================================
+ Hits         2719     2741      +22     
+ Misses        872      868       -4     
+ Partials      218      217       -1
Impacted Files Coverage Δ
model/model.go 95.73% <ø> (ø)
server/persistence/mysql/interaction.go 54.02% <ø> (ø)
server/persistence/mysql/players.go 69.64% <ø> (ø)
server/setup.go 0.00% <ø> (ø)
server/persistence/mysql/test_utils.go 50.00% <50.00%> (ø)
jsonutils/gameUnmarshaller.go 60.00% <100.00%> (+2.86%) :arrow_up:
network/player.go 100.00% <100.00%> (ø)
server/persistence/memory/memory_service_game.go 76.56% <100.00%> (+0.37%) :arrow_up:
server/persistence/mongodb/mongodb_service_game.go 72.67% <100.00%> (+0.18%) :arrow_up:
server/persistence/mysql/games.go 72.83% <100.00%> (+1.11%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df83d8e...6092b54. Read the comment docs.