Closed cszczepaniak closed 4 years ago
Merging #79 into master will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 71.64% 71.69% +0.05%
==========================================
Files 73 73
Lines 3826 3826
==========================================
+ Hits 2741 2743 +2
+ Misses 868 867 -1
+ Partials 217 216 -1
Impacted Files | Coverage Δ | |
---|---|---|
server/play/cut.go | 52.78% <0.00%> (+5.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9b9808f...b891bfe. Read the comment docs.
also, we're failing to build because:
The react-scripts package provided by Create React App requires a dependency:
"eslint": "^6.6.0"
Don't try to install it manually: your package manager does it automatically.
However, a different version of eslint was detected higher up in the tree:
/app/node_modules/eslint (version: 7.4.0)
QA+1 lgtm
What broke / What you're adding
Changing over from the old stuff (tailwind) to our new found best friend: Material UI.
Here's a peek with the drawer pulled out:
Layout.jsx
, which handles the app skeletonHow you did it
For the drawer, I followed (read: copied) the examples here. For the other stuff, I followed various examples from the Material UI doc for various components (most notably, forms).
How to test it and how to try to break it
Stand up the server, start the client. See the new beautiful (albeit very google-y) UI. Try the drawer. See that it changes if you're logged in. See that the login/logout and navigation buttons work.