Closed cszczepaniak closed 4 years ago
Merging #82 into master will decrease coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 71.78% 71.73% -0.05%
==========================================
Files 73 73
Lines 3849 3849
==========================================
- Hits 2763 2761 -2
- Misses 869 870 +1
- Partials 217 218 +1
Impacted Files | Coverage Δ | |
---|---|---|
server/play/cut.go | 47.22% <0.00%> (-5.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3cdd24a...a2d2807. Read the comment docs.
@joshprzybyszewski all the lint errors are fixed, so this one's getting close to being ready to merge once you review
What broke / What you're adding
../../
hellNode doesn't do great with our root directory not being a node application (with a
package.json
). If you want vscode to use the locally installed eslint, follow these stepscd
intoclient/
and do annpm install
client/
instead of from our root! (this is a pain but otherwise vscode doesn't pick up anything)How you did it
Absolute paths Linting workflow
How to test it and how to try to break it
shrug run the app, see it still work with new import paths. Push react code up, get rekt by eslint