Closed cszczepaniak closed 3 years ago
Merging #90 (fcb94e2) into master (d9399dc) will increase coverage by
0.75%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 69.32% 70.07% +0.75%
==========================================
Files 73 80 +7
Lines 3354 3465 +111
==========================================
+ Hits 2325 2428 +103
- Misses 813 819 +6
- Partials 216 218 +2
Impacted Files | Coverage Δ | |
---|---|---|
model/card.go | 93.68% <0.00%> (-4.07%) |
:arrow_down: |
logic/strategy/card_utils.go | ||
logic/strategy/toss_evaluator.go | 76.47% <0.00%> (ø) |
|
network/suggest.go | 100.00% <0.00%> (ø) |
|
logic/suggestions/handToss.go | 95.00% <0.00%> (ø) |
|
logic/strategy/calculated_toss.go | 84.62% <0.00%> (ø) |
|
logic/suggestions/utils.go | 95.56% <0.00%> (ø) |
|
model/test_utils.go | 100.00% <0.00%> (ø) |
|
network/test_utils.go | 100.00% <0.00%> (ø) |
|
logic/suggestions/tossStats.go | 89.47% <0.00%> (ø) |
|
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d9399dc...fcb94e2. Read the comment docs.
What broke / What you're adding
Addresses #73 :tada:
redux-saga
are pretty irrelevant. Therefore, I've ripped all that out and created some custom hooks to handle that stuff for us. No more chasing down sagas that get called out of thin air. Hooray!How to test it and how to try to break it
Everything should :tm: work exactly as it used to. I played through a partial game, and everything seems to be mostly in ship shape, but you should try to break it too.
Disclaimer: this PR is lorge. sorry. Also, the diff makes it looks like everything is new because I renamed every. single. file. sorry again.