joshprzybyszewski / cribbage

A cribbage scorer and game
MIT License
2 stars 1 forks source link

Use docker-compose to set up the app locally #98

Closed joshprzybyszewski closed 3 years ago

joshprzybyszewski commented 3 years ago

What broke / What you're adding

I want to add dynamoDB as a persistence option. The first step is to be able to test locally. What seemed like the easiest thing to do is to use docker-compose.

How you did it

Let's add a docker-compose that runs the app locally. This will also follow some of the internet's instructions for setting up dynamoDB.

How to test it and how to try to break it

run docker-compose up cribbage-server and go to localhost:18080 and be able to play a game!

codecov[bot] commented 3 years ago

Codecov Report

Merging #98 (bd674e3) into master (091c0b1) will decrease coverage by 0.15%. The diff coverage is 0.00%.

:exclamation: Current head bd674e3 differs from pull request most recent head 878a6bd. Consider uploading reports for the commit 878a6bd to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   70.07%   69.92%   -0.15%     
==========================================
  Files          80       80              
  Lines        3465     3471       +6     
==========================================
- Hits         2428     2427       -1     
- Misses        819      826       +7     
  Partials      218      218              
Impacted Files Coverage Δ
server/persistence/mysql/mysql.go 76.09% <0.00%> (-5.31%) :arrow_down:
server/setup.go 0.00% <0.00%> (ø)
logic/strategy/calculated_hand.go 50.00% <0.00%> (-50.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 091c0b1...878a6bd. Read the comment docs.

cszczepaniak commented 3 years ago

QA looks good, was able to play games as normal. Maybe we want a make target that runs docker-compose up -d cribbage-server?