joshpxyne / gpt-migrate

Easily migrate your codebase from one framework or language to another.
https://gpt-migrate.com
MIT License
6.85k stars 485 forks source link

Target repository doesn't make use of internal functions #26

Closed MkuuWaUjinga closed 1 year ago

MkuuWaUjinga commented 1 year ago

Saw this using the benchmark flask-nodejs:

app.js is not importing db.js but instead uses an external library node-json-db: const db = new JsonDB(new Config("storage/items", true, false, '/'));.

What about adding the internal function signatures, which the source file depends on, to the migration prompt for the target file? This should probably fix it :) Related to #5.

joshpxyne commented 1 year ago

It's non-deterministic unfortunately so I won't have the same errors that you have. If you run it again or let the debugger work it'll likely fix it (eventually). Certainly agreed that #5 will help!

MkuuWaUjinga commented 1 year ago

Yeah, I get it roughly every second time I do the migration. Debugging doesn't help as all the generated tests are green. Is somebody already working on #5? Happy to add a PR

joshpxyne commented 1 year ago

Please feel free to submit a PR!