search

joshrps / laravel-shopify-API-wrapper

Interface designed for Shopify apps created with Laravel
MIT License
93 stars 48 forks source link

Bug in timestampcheck #6

Open VesninAndrey opened 9 years ago

VesninAndrey commented 9 years ago

https://github.com/joshrps/laravel-shopify-API-wrapper/blob/master/src/RocketCode/Shopify/api.php#L55

It must be time() - $input['timestamp'] < 3600 because (time() > $input['timestamp'])
($input['timestamp'] - time() < 0)

joshrps commented 9 years ago

Actually, shouldn't it be more like abs($da['timestamp'] - time()) > 3600 ?

VesninAndrey commented 9 years ago

Don't care. Just bug.