search

joshspeagle / brutus

Modeling stellar photometry with "brute force" methods
MIT License
32 stars 5 forks source link

Fix numpy arrays being modified out of scope #40

Closed gusbeane closed 4 years ago

gusbeane commented 4 years ago

Found in _optimize_fit, where the input av will be modified outside of scope. Does not affect results at the moment, but should be cleaned up at some point to prevent future errors. (And should be found in other parts of code.)

joshspeagle commented 4 years ago

This technically is accessible to the users but only through functions tagged as internal, but I agree I should probably make things a bit safer here.

joshspeagle commented 4 years ago

With the refactoring of these functions, I don't think this is actually as much of a concern for the immediate time being. I'm going to close this for now. We can reopen it if it becomes a problem again.