search

joshspeagle / brutus

Modeling stellar photometry with "brute force" methods
MIT License
32 stars 5 forks source link

wt_thresh duplicate #41

Closed gusbeane closed 4 years ago

gusbeane commented 4 years ago

There shouldn't be two wt_thresh variables running around.

joshspeagle commented 4 years ago

Yes, I should redefine the internals of loglike and any other associated functions to actually track the variable names used in fit. Thanks.

gusbeane commented 4 years ago

In fit, the parameter log_initthresh is passed to _optimize_fit as init_thresh, and within _optimize_fit the action log(init_thresh) is taken, so this breaks a user-facing parameter, since one would often want to set log_initthresh < 0. Adding a bug label

joshspeagle commented 4 years ago

Note that it is technically logl, not log. So this isn't actually a bug.