search

joshspeagle / brutus

Modeling stellar photometry with "brute force" methods
MIT License
32 stars 5 forks source link

add in preliminary prior evaluation before cuts #46

Closed joshspeagle closed 3 years ago

joshspeagle commented 3 years ago

In fitting, when evaluating the posterior I clip aggressively using only "static" priors (exact line here). This appears to cause problems when, for instance, the distance prior changes dramatically. I should look into whether evaluating the prior for the MLE values for (s, A, R) over a chunk of the grid actually fixes this and doesn't dramatically increase the runtime.

Thanks to @catherinezucker for tracking this failure mode down!

joshspeagle commented 3 years ago

This was mostly resolved in https://github.com/joshspeagle/brutus/commit/9450a9de90a9c7c3ad8123fb5283671d4d2df1e5, which includes clipping based on the MLE solution.