joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences
https://dynesty.readthedocs.io/
MIT License
357 stars 77 forks source link

Closes #118 #119

Closed GregoryAshton closed 5 years ago

GregoryAshton commented 5 years ago

Fixes minor bug in merge_results

I did try to add a dosctring, but I'm a little confused on exactly what samples_n acually is. Feel free to edit yourself or let me know what to fill in/otherwise change.

joshspeagle commented 5 years ago

samples_n is the number of live points at a given iteration (associated with a particular dead point/sample). It's defined somewhere in the docs, but I probably should try to improve the internal documentation to make this easier to understand.

As for the PR, this looks great. Would you be able to make a few (very minor) changes for style?

Once that's done I'm happy to merge this in!

GregoryAshton commented 5 years ago

Thanks for the info - I've addressed the comments :)

joshspeagle commented 5 years ago

Looks great! Merged and resolves #118.