joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences
https://dynesty.readthedocs.io/
MIT License
357 stars 77 forks source link

fix the problems with random seeds in tests. #249

Closed segasai closed 3 years ago

segasai commented 3 years ago

previously tests influenced each other. Now each script has its own seed set up by pytest.fixture.

joshspeagle commented 3 years ago

Should I plan to review and accept both this and #248 then?

segasai commented 3 years ago

This patch is non-controversial, ready to be reviewed and committed. The #248 needs a careful separate look/review. I am not 100% certain in its correctness. But #248 is ready for review too

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 854323841


Files with Coverage Reduction New Missed Lines %
py/dynesty/utils.py 1 41.47%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 839449013: -0.02%
Covered Lines: 3365
Relevant Lines: 4681

💛 - Coveralls