Kwargs fix - Githubissues

joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences

https://dynesty.readthedocs.io/

MIT License

347 stars 76 forks source link

Kwargs fix #295

Closed segasai closed 3 years ago

segasai commented 3 years ago

Attempt to address #293 1) I remove **kwargs from Nested and Dynamic samplers 2) add nlive parameter to Dynamic samplers that will be used as default nlive_init/nlive_batch if those are not specified.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 950336769

8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 80.361%

Totals
Change from base Build 948788945:	0.03%
Covered Lines:	3691
Relevant Lines:	4593

💛 - Coveralls

joshspeagle commented 3 years ago

Is this stable and ready to be reviewed and merged?

segasai commented 3 years ago

Yes, It is. The docs will need some adjustment (later though)

joshspeagle commented 3 years ago

No problem wrt the docs. I can always add that in later when I'm trying to collect all these changes into v1.2.