joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences
https://dynesty.readthedocs.io/
MIT License
347 stars 76 forks source link

Namedtuple iterator change #309

Closed segasai closed 3 years ago

segasai commented 3 years ago

Although it could have been an option after 1.2, I thought addressing #307 is worthwhile as currently things are error-prone. now all the iterators return namedtuples and I think the code is cleaner. There is a fair bit of repeated code stuff and it may be refactored in the future, but it looks worth applying.

I've also yanked the kl_divergence.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1154738947


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/dynesty/dynesty.py 20 22 90.91%
py/dynesty/bounding.py 31 35 88.57%
py/dynesty/dynamicsampler.py 44 50 88.0%
py/dynesty/utils.py 32 39 82.05%
py/dynesty/nestedsamplers.py 35 46 76.09%
py/dynesty/plotting.py 4 16 25.0%
<!-- Total: 208 250 83.2% -->
Files with Coverage Reduction New Missed Lines %
py/dynesty/dynamicsampler.py 1 88.63%
py/dynesty/nestedsamplers.py 1 90.54%
py/dynesty/bounding.py 3 82.27%
<!-- Total: 5 -->
Totals Coverage Status
Change from base Build 1149496823: 0.7%
Covered Lines: 3453
Relevant Lines: 4252

💛 - Coveralls
segasai commented 3 years ago

This is ready to be reviewed after the tests pass (they take longer now) This PR contains

It fixes #307 , #308 and deals somewhat with #310 (TBC)

segasai commented 3 years ago

Thanks