joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences
https://dynesty.readthedocs.io/
MIT License
347 stars 76 forks source link

improve the rwalk behaviour for difficult cases. #384

Closed segasai closed 2 years ago

segasai commented 2 years ago

This is a small but useful improvement. When doing random walk sampling the walking consists of two parts.

These steps are repeated 'walks' times. Sometimes even the first step generation of a point can fail, because say the ellipsoid is longer than the cube and a generated point is outside. Now I do not consider that as a 'walk'. I only consider walk attempts that are within the cube and that get a function evaluation. That should make things more stable and reduce situations when the none of walking steps are accepted (i.e. #354 )

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2870843094


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/dynesty/sampling.py 3 4 75.0%
<!-- Total: 3 4 75.0% -->
Totals Coverage Status
Change from base Build 2863436648: -0.02%
Covered Lines: 3669
Relevant Lines: 4058

💛 - Coveralls
segasai commented 2 years ago

That was not a good idea. that still breaks the detailed balance. Closing.