joshspeagle / dynesty

Dynamic Nested Sampling package for computing Bayesian posteriors and evidences
https://dynesty.readthedocs.io/
MIT License
347 stars 76 forks source link

Proposal update change #385

Closed segasai closed 2 years ago

segasai commented 2 years ago

This is a change trying to address how tuning of proposal distributions is done. Previously only 'blob' returned from one every 'queue_size' was used to adjust the tuning params. With this change the update_PROPOSAL() are called every time to mostly accumulate statistics on number of acceptances and rejects and the actual update will happen still every queue_size.

The advantages are

Disadvantages:

I think the advantages are worth it, but I think some refactoring may be warranted, like grouping the samplers in a separate classes, so they can keep the information there

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2904104172


Changes Missing Coverage Covered Lines Changed/Added Lines %
py/dynesty/nestedsamplers.py 36 38 94.74%
<!-- Total: 39 41 95.12% -->
Totals Coverage Status
Change from base Build 2884196862: 0.04%
Covered Lines: 3738
Relevant Lines: 4129

💛 - Coveralls