Closed segasai closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
py/dynesty/dynamicsampler.py | 130 | 133 | 97.74% | ||
py/dynesty/utils.py | 41 | 49 | 83.67% | ||
py/dynesty/dynesty.py | 132 | 142 | 92.96% | ||
<!-- | Total: | 319 | 340 | 93.82% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
py/dynesty/sampler.py | 2 | 91.16% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 2911341179: | 0.04% |
Covered Lines: | 3831 |
Relevant Lines: | 4230 |
This is starting to get ready for review.
Thanks for taking a look!
I think this is ready for a final review and merge.
If we feel that more docs/examples are needed that may be done after the merge. The docs for the branch should be available here https://dynesty.readthedocs.io/en/resuming/
The only thing extra I can think of here, is of some way of usilng say dill instead of pickle. I don't quite know if it's better to just always use dill or think of an option to switch the pickler. (but this stuff should go after this is merged)
Hi @joshspeagle If you could take a look/rereview the PR that would be great, otherwise, I will aim to merge this early next week. Thanks
Thanks, @joshspeagle ! Merging
This a preliminary version of code that allows resuming of dynesty runs. The current interface is this is to run:
And to resume
This was used to test it
There are quite a few things that need fixing.
I only implemented interruption for run_nested interface. I don't plan to implement interruption of an iterator interface.