Stop mutating input in `lkml.dump`

joshtemple / lkml

A speedy LookML parser & serializer implemented in pure Python.

MIT License

166 stars 31 forks source link

Stop mutating input in `lkml.dump` #74

Closed joshtemple closed 2 years ago

joshtemple commented 2 years ago

We shouldn't directly mutate the input when calling .dump in case it needs to be reused by the user. Instead, we should make a copy before operating on it.

Closes #61.

samjewell commented 2 years ago

Awesome! Thanks for this 🙏