search

joshua-decoder / joshua

Joshua Statistical Machine Translation Toolkit
http://joshua-decoder.org/
121 stars 56 forks source link

Fixed failing tests #227

Closed fhieber closed 9 years ago

fhieber commented 9 years ago

Fixes 3 failing tests: test/./lm/berkeley, /thrax/extraction, decoder/target-bigram.

mjpost commented 9 years ago

Thanks! When updating the thrax test case, why did the file sizes differ? Can you post a diff of the contents so we can see what changed?

fhieber commented 9 years ago

The test does not have a 'gold' output so I don't know what changed there. Did this test pass for you in its original form?

mjpost commented 9 years ago

This must have changed with the Hadoop 2.5.2 upgrade. I get the same result as you, so all looks good. Thanks!