search

joshua-decoder / joshua

Joshua Statistical Machine Translation Toolkit
http://joshua-decoder.org/
121 stars 56 forks source link

Unbound variable in joshua-decoder script #234

Open lewismc opened 9 years ago

lewismc commented 9 years ago

This was reported by the Homebrew Jenkins CI build server

Error Message

failed: brew test --verbose joshua

Stacktrace

        Testing joshua
==> Using the sandbox
/usr/bin/sandbox-exec -f /tmp/homebrew20151106-70367-hbqww0.sb /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby -W0 -I /usr/local/Library/Homebrew -- /usr/local/Library/Homebrew/test.rb /usr/local/Library/Formula/joshua.rb --verbose
==> /usr/local/Cellar/joshua/6.0.5/bin/joshua-decoder -version
/usr/local/Cellar/joshua/6.0.5/bin/joshua-decoder: line 27: JOSHUA: unbound variable
Error: joshua: failed
Failed executing: /usr/local/Cellar/joshua/6.0.5/bin/joshua-decoder -version
/usr/local/Library/Homebrew/formula.rb:1431:in `block in system'
/usr/local/Library/Homebrew/formula.rb:1368:in `open'
/usr/local/Library/Homebrew/formula.rb:1368:in `system'
/usr/local/Library/Formula/joshua.rb:59:in `block in <class:Joshua>'
/usr/local/Library/Homebrew/formula.rb:1277:in `block in run_test'
/usr/local/Library/Homebrew/extend/fileutils.rb:17:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:1273:in `run_test'
/usr/local/Library/Homebrew/test.rb:28:in `block in <main>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
/usr/local/Library/Homebrew/test.rb:27:in `<main>'
mjpost commented 9 years ago

$JOSHUA/bin/joshua-decoder requires that $JOSHUA be defined. I will push up a change that instead sets this from within the script based on the path of the called file.

lewismc commented 9 years ago

That would be nice. Please feel free to rename this issue @mjpost

mjpost commented 9 years ago

Should be fixed now, in the dist. tarballs as well.

lewismc commented 9 years ago

@mjpost

in the dist. tarballs as well.

Do you mean that this is present in the new Joshua 6.0.5? Did you respin the release? I've cleared my cache and spinning it from scratch.

mjpost commented 9 years ago

Yes, this is now fixed in the downloadable tarballs.

matt (from my phone)

On Nov 6, 2015, at 9:42 PM, Lewis John McGibbney notifications@github.com wrote:

@mjpost

in the dist. tarballs as well.

Do you mean that this is present in the new Joshua 6.0.5? Did you respin the release?

— Reply to this email directly or view it on GitHub.