Make code snippets pass puppet-lint

joshuabaird / puppet-ipaclient

Puppet module to manage IPA client installation. Please fork and contribute!

https://forge.puppetlabs.com/joshuabaird/ipaclient

MIT License

12 stars 23 forks source link

Make code snippets pass puppet-lint #60

Closed bittner closed 6 years ago

bittner commented 7 years ago

Fixes a few syntax errors and styling issues that puppet-lint would detect.
Adds the use of the $::domain variable and upcase() as an example for a generic implementation.

bittner commented 6 years ago

@joshuabaird Can you press the merge button here, too?

joshuabaird commented 6 years ago

I’ll take care of this and tag a new Forge release in a bit!

On Nov 27, 2017, at 4:01 AM, Peter Bittner notifications@github.com wrote:

@joshuabaird Can you press the merge button here, too?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

bittner commented 6 years ago

@joshuabaird Please press the merge button here! It's just the README. Thank you!

joshuabaird commented 6 years ago

My bad. Merged.

bittner commented 6 years ago

Thanks!

A release on Puppet Forge would now be cool. Can you make this happen?

joshuabaird commented 6 years ago

Done. 2.5.2 released to Forge.

On Tue, Dec 5, 2017 at 3:35 PM, Peter Bittner notifications@github.com wrote:

Thanks!

A release on Puppet Forge would now be cool. Can you make this happen?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/joshuabaird/puppet-ipaclient/pull/60#issuecomment-349432886, or mute the thread https://github.com/notifications/unsubscribe-auth/AF-zrnWITzSZWQYqUuqo-aNn4k2obUmuks5s9akKgaJpZM4PwwTZ .

bittner commented 6 years ago

Great! The released module proves to be working fine for a couple of days already. Thanks again!