search

joshuabaird / puppet-ipaclient

Puppet module to manage IPA client installation. Please fork and contribute!
https://forge.puppetlabs.com/joshuabaird/ipaclient
MIT License
12 stars 23 forks source link

implement --force-join parameter #62

Closed clecherbauer closed 6 years ago

clecherbauer commented 6 years ago

This solves #61

bittner commented 6 years ago

This PR now fixes both issue #61 and the broken build matrix. All tests now pass.

61:

When client is already joined, "ipa-client-install" fails. According to the freeipa project the --force-join option allows to override this limitation.

clecherbauer commented 6 years ago

Are there any concerns about merging these changes?

This parameter especially helps to avoid user interaction if you want to reinstall a computer that is already joined in freeIPA. Otherwise you need to delete the machine from freeipa before reinstallation.

bittner commented 6 years ago

@joshuabaird @stbenjam Can anyone of you guys merge this PR, or at least comment on it?

Is this project still maintained?

joshuabaird commented 6 years ago

Merged. Unfortunately , this module is not maintained as well it should be anymore. Happy to review and merge any fixes or enhancements though.

bittner commented 6 years ago

Yay! :tada:

bittner commented 6 years ago

A release on Puppet Forge would be cool. Could you make this happen?