search

joshuabenuck / seran-wiki

Experiment to create a Deno based implementation of Federated Wiki
MIT License
11 stars 7 forks source link

multiple controls with state in objects #13

Closed WardCunningham closed 4 years ago

WardCunningham commented 4 years ago

We show that multiple buttons can control the various loops. Maybe wrap some code into something instantiated to avoid duplication.

I was almost done following this strategy when I realized there was only one function to be run. The steps in the nested loop are not independent as they are in this design: http://ward.asia.wiki.org/stepping-the-async-scrape.html

I can make this work if all of the steps are running=true except one on any page.

image

This lacks the interlocks to make sure every button press makes sense.

WardCunningham commented 4 years ago

With so many indention changes it is hard to see what I actually did. I think a better strategy would be to no correctly indent, check in the changes, and then run the formatter to get all of that out of the way in one commit that needs little examination. I hope I remember this idea.

joshuabenuck commented 4 years ago

Do you want me to hold off on merging this then?

WardCunningham commented 4 years ago

No, the distinction has been lost now. I was just apologizing that this is hard to review. I preserved the old "simple" version just so it would be easy to see that it still worked, if you cared to check.

joshuabenuck commented 4 years ago

Tripple should be Triple

WardCunningham commented 4 years ago

I'll fix it. It look wrong but my spell check was happy.

joshuabenuck commented 4 years ago

The split view makes it much easier to see and understand what changed.